search

calrissian / mango

Common utilities for rapid application development
Apache License 2.0
17 stars 7 forks source link

Cleanup of JmsDecorators 2 #42

Closed eawagner closed 10 years ago

eawagner commented 11 years ago

More work to address issue Issue #25.

-Renamed the decorators to be more specific to their purpose.
-Made all classes but the ConnectionFactory implementations package private.
-Modified the SingleTopicConnectionFactory to leave Queues alone and vise versa for SingleQueueConnectionFactory decorator.
-Fixed stream implementation to always send data over a topic instead of the approach of trying to guess the destination type, which was not always correct.

cjnolet commented 11 years ago

I had a rough time in abstract method hell implementing the Distributed Click To Content stuffs because of the decorators. If you don't mind, I'd like to merge this in when I (or someone with access to the original codebase... i.e. cyber insight) gets a chance to verify that the jms data chunking services all still work. Sadly, there's no functional tests for that.

eawagner commented 11 years ago

I actually changed the JmsFileTransferSupportTest to use the single topic decorator to test this out. This is how I found problems with the service having problems determining if an endpoint was a topic or a queue.

So by integrating with that test, we are able to test out each of these implementations to verify the functional capabilities. We do need more and better tests though for this code.