search

caltechlibrary / cell-atlas

Cell atlas
https://cellstructureatlas.org
Other
5 stars 2 forks source link

Image Comparison Slider #6

Closed KianBadie closed 3 years ago

KianBadie commented 3 years ago

Things to implement:

Initial Mock

still

KianBadie commented 3 years ago

@coiko I added a grey stroke to the video/image tabs and borders to better show which option is currently selected. Is the gif below along the lines of what you were thinking about? I showed an example in the modal to highlight how the stroke would need to be added to the video citation in order to fit.

Should we also add this thin grey stroke to all video/slider containers we have? For example, the mobile main section slider does not use the tab system, but do you think it would be good to add for consistency?

Gif

border

coiko commented 3 years ago

@KianBadie Oh how cool! It looks great! And yes, for consistency, it's probably good to apply it to all the containers, even if they don't have tabs.

KianBadie commented 3 years ago

@coiko Awesome! I will go ahead and merge that in soon.

KianBadie commented 3 years ago

@coiko It's merged! It did get rid of the old shadows for the buttons. Was that an aspect that you liked? I can always add it back in! Or do you like things as they are with the new stroke w/o shadows?

Old

oldPNG

New

newPNG

coiko commented 3 years ago

Thanks @KianBadie! The shadows were cool, but they're certainly not necessary (especially since they're only very visible in modals), so I wouldn't worry about them unless you want to.

KianBadie commented 3 years ago

@coiko No problem! I will go ahead and leave them out then as I do not think they are critical either.