search

caltechlibrary / iga

IGA is the InvenioRDM GitHub Archiver, a standalone program as well as a GitHub Action that lets you automatically archive GitHub software releases in an InvenioRDM repository.
https://caltechlibrary.github.io/iga/
Other
8 stars 1 forks source link

Gitlab integration #43

Open panta-123 opened 2 months ago

panta-123 commented 2 months ago

Description

Closes: #42 #40 This allows gitlab integration. Added CLI options:

  1. --gitlab : to say that this is gitlab specific repo. (triggers gitlab flow)
  2. --gitlab-url : If not using URl , and using account , repo ,
  3. --gitlab-projectid: specify the project ID as ID or path of url.

Interface to gitlab is made in gitlab.py. A comman inteferace that pass the info to gitlab or github is made, (githublab.py) , it calls gitlab.py if --gitlab is specified.

Aditonal: closes the rich optionhighlighter issue aswell.

Questions: In cli help , the text says --account but that option is not there. The available option is --github-account. Should we change to --account (as this will be not github/gitlab specicifc).

Also there are option --github-token and --github-repo , should this be changed to --git-token and --git-repo repectively. So that we will be NOT be github/gitlab specific.

Software environment

Please include the following information:

Checklist

Please check that the following have been done:

tmorrell commented 2 months ago

Thanks for the contribution! We likely won’t be able to review until early August

panta-123 commented 1 month ago

@tmorrell any update here ?

tmorrell commented 1 month ago

We've had some staffing changes, but it's on our list to review soon. Hopefully by the end of the month!

One quick comment, it would be great to add some gitlab tests like https://github.com/caltechlibrary/iga/blob/develop/tests/test_github_mocks.py and https://github.com/caltechlibrary/iga/blob/develop/tests/test_github.py. Since we don't use gitlab at Caltech having tests is important to make sure we don't break anything.

panta-123 commented 1 month ago

working on it. next commit within this week.

panta-123 commented 1 month ago

added the pytest for gitlab.

panta-123 commented 1 month ago

@tmorrell , added the pytest similar to github and github_mocks. Some extra test on cli as well.