caltechlibrary / irdmtools

A Go and Python package for working with InvenioRDM repositories.
https://caltechlibrary.github.io/irdmtools
Other
1 stars 1 forks source link

Put 'suggests' private notes into review comments #16

Closed tmorrell closed 1 year ago

tmorrell commented 1 year ago

Will require a modification of the add_to_community function

rsdoiel commented 1 year ago

Note to self: This needs to happen in eprints_to_rdm.py after the send_to_community but before review_request.

rsdoiel commented 1 year ago

From issue #47, "suggestions" now map to custom field "caltech:internal_note". These need to be removed and saved before saving a draft, and pushed up as a review comment before review_request.

rsdoiel commented 1 year ago

Before fixup_record is called I extract the value in .custom_fields["caltech:internal_note"], the fixup_record will strip that field. Later when update_record is called I pass an added parameter of internal_note. If that is a non-empty string then before review_request "accept" is done a "review_comment" is called with the value of internal_note.

rsdoiel commented 1 year ago

Fixed in upcoming release v0.0.40.