caltechlibrary / irdmtools

A Go and Python package for working with InvenioRDM repositories.
https://caltechlibrary.github.io/irdmtools
Other
1 stars 1 forks source link

eprint2rdm, creators as editor #9

Closed rsdoiel closed 1 year ago

rsdoiel commented 1 year ago

The following EPrints for the records in CaltechAUTHORS should reflect the "editor" role in creator rather than contributor. eprint2rdm needs to reflect that has a rule, if not author but editor then editor goes in creator role with role of editor.

31270 77623 78903 74897 69976 80062 49710 44801 44555 70859 54340 25071 25067 77591 70667

rsdoiel commented 1 year ago

Need to confirm I'm rendering the JSON right for role in .metadata.creators for the EPrint ID rendered as RDM JSON.

{
    "person_or_org": {
      "type": "personal",
      "given_name": "Roger",
      "family_name": "Ghanem",
      "name": "Ghanem, Roger"
    },
    "role": {
      "title": {
        "en": "editor"
      }
    }
  },
rsdoiel commented 1 year ago

Corrected it to look like.

[
  {
    "person_or_org": {
      "type": "personal",
      "given_name": "Henry Lutz",
      "family_name": "Ehrlich",
      "name": "Ehrlich, Henry Lutz"
    },
    "role": {
      "id": "editor"
    }
  },
  {
    "person_or_org": {
      "type": "personal",
      "given_name": "Dianne K.",
      "family_name": "Newman",
      "name": "Newman, Dianne K."
    },
    "role": {
      "id": "editor"
    }
  }
]
rsdoiel commented 1 year ago

This is fixed in the upcoming v0.0.17 release.