search

caltry / Bikeshed

Bikeshed is an operating system being re-written in Node.js
http://www.freelists.org/list/bikeshed
4 stars 1 forks source link

Makedepend warnings #1

Closed wlitwin closed 12 years ago

wlitwin commented 12 years ago

makedepend: warning: startup.s, line 1: unknown directive == "# 1 "startup.S"" makedepend: warning: startup.s, line 2: unknown directive == "# 1 """ makedepend: warning: startup.s, line 3: unknown directive == "# 1 """ makedepend: warning: startup.s, line 4: unknown directive == "# 1 "startup.S"" makedepend: warning: startup.s, line 5: unknown directive == "# 20 "startup.S"" makedepend: warning: startup.s, line 6: unknown directive == "# 1 "bootstrap.h" 1" makedepend: warning: startup.s, line 7: unknown directive == "# 21 "startup.S" 2" makedepend: warning: startup.s, line 8: unknown directive == "# 51 "startup.S"" makedepend: warning: startup.s, line 109: unknown directive == "# 159 "startup.S"" makedepend: warning: startup.s, line 139: unknown directive == "# 224 "startup.S"" makedepend: warning: startup.s, line 142: unknown directive == "# 236 "startup.S"" makedepend: warning: startup.s, line 166: unknown directive == "# 268 "startup.S""

Only on makedepend.mk creation

caltry commented 12 years ago

This only happens when doing a build that is not proceeded by a "make clean"?

This is likely in defs.mk:19 when I set the wildcard to search for source files. I should exclude the derived assembly (*.s) files from being considered "source" files.

DYN_SRC_FILES = $(shell ls *.[chsS])

Everything's safe for now. I'll test the fix and get it out probably by the end of the day.

caltry commented 12 years ago

So, there are two ways to interpret this bug. Either (i) make clean should be cleaning up all *.s files (because they're derived sources and not in version control) or (ii) I should change DYN_SRC_FILES as described above.

What sounds better?

wlitwin commented 12 years ago

cleanup the .s files, because I don't like them

On Sat, Apr 14, 2012 at 12:05 AM, David Larsen < reply@reply.github.com

wrote:

So, there are two ways to interpret this bug. Either (i) make clean should be cleaning up all *.s files (because they're derived sources and not in version control) or (ii) I should change DYN_SRC_FILES as described above.

What sounds better?

Reply to this email directly or view it on GitHub: https://github.com/caltry/Bikeshed/issues/1#issuecomment-5128672

caltry commented 12 years ago

Fixed in ba1b0288163f6d7289f1d652585585af2786b84d.