calum-chamberlain / ESCI451-Python

Introduction to Python for VUW ESCI 451 course.
GNU General Public License v3.0
11 stars 5 forks source link

More seaborn examples #16

Closed FinniganIK closed 2 years ago

FinniganIK commented 2 years ago

Added seaborn plotting examples and a new geochemistry dataset into data

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

calum-chamberlain commented 2 years ago

This looks great Finn! Do you want to make sure that the correct data are loaded by re-loading the dataframe before each plot (if reading the data doesn't take too long)? I can imagine someone re-running one of the earlier plots after loading the second geochemdata...

calum-chamberlain commented 2 years ago

P.S. I will fix the tests shortly - that was my doing yesterday, sorry!

FinniganIK commented 2 years ago

Yeah good call, I'll make that fix now

calum-chamberlain commented 2 years ago

Golden, thanks Finn - I have got the tests passing on master as well so hopefully this goes green.

Would you be able to add an exercise or two to this? Just simple "try making this plot..." or "now get some other data and make a nice plot"?

my "S" key is dodgy, I need to replace the switch...

FinniganIK commented 2 years ago

Couple of exercises added now

calum-chamberlain commented 2 years ago

Looks good to me - are you happy for me to merge this?

FinniganIK commented 2 years ago

Yep merge away