Closed FinniganIK closed 2 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
This looks great Finn! Do you want to make sure that the correct data are loaded by re-loading the dataframe before each plot (if reading the data doesn't take too long)? I can imagine someone re-running one of the earlier plots after loading the second geochem
data...
P.S. I will fix the tests shortly - that was my doing yesterday, sorry!
Yeah good call, I'll make that fix now
Golden, thanks Finn - I have got the tests passing on master as well so hopefully this goes green.
Would you be able to add an exercise or two to this? Just simple "try making this plot..." or "now get some other data and make a nice plot"?
my "S" key is dodgy, I need to replace the switch...
Couple of exercises added now
Looks good to me - are you happy for me to merge this?
Yep merge away
Added seaborn plotting examples and a new geochemistry dataset into data