Define pygmt version in environment.yml

calum-chamberlain / ESCI451-Python

Introduction to Python for VUW ESCI 451 course.

GNU General Public License v3.0

11 stars 5 forks source link

Define pygmt version in environment.yml #32

Closed FinniganIK closed 1 year ago

FinniganIK commented 1 year ago

Specified pygmt=0.8.0 There is a difference in syntax for defining symbol color in plot (color vs fill) between v0.7 and v0.8 which caused problems in my updated environment

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

calum-chamberlain commented 1 year ago

Thanks @FinniganIK, when I made clean envs for this year I automatically got pygmt 0.8 and had updated the color/fill args. Can I check that the only change you explicitly made in this branch was updating the env? If so I will close this once the todo list below is complete.

TODO:

[x] Check environment deployed in CO501 (if it is pygmt 0.8, then this is a simple change, if not then I will need to update pygmt to 0.8)
[x] Update env on master
[x] Update env on 2023 release
[x] Re-release 2023 release
[x] Close PR (without merging)

FinniganIK commented 1 year ago

Yeah that's right, I think the problem only arose because I updated my local esci451 environment rather than reinstalling it. Because the env had pygmt >= 0.7.0 it left the pygmt version as 0.7.0 and so the color/fill arg threw up an error.

So yep, the only change I made was updating the env

FinniganIK commented 1 year ago

I really messed up this pull request! Soz