calum74 / s2

Cross platform command line interface to the Spooky2
GNU General Public License v3.0
16 stars 8 forks source link

strlen error after make command #5

Open juroun opened 2 years ago

juroun commented 2 years ago

Hi there,

Thanks for this spooky2 control software on linux. I'm experiencing a problem while trying to get it installed. As can be seen below, an error popped up after the make command while in the s2 directory. It says: error strlen was not declared in this scope. I'm new to linux, so I'm not savvy enough to find a solution myself. So thanks in advance for any possible help!

Have a nice weekend, Greetings, Jeroen

~/s2$ make Scanning dependencies of target s2core [ 4%] Building CXX object CMakeFiles/s2core.dir/src/Control.cpp.o [ 9%] Building CXX object CMakeFiles/s2core.dir/src/Database.cpp.o [ 13%] Building CXX object CMakeFiles/s2core.dir/src/Devices.cpp.o [ 18%] Building CXX object CMakeFiles/s2core.dir/src/FindCommand.cpp.o /home/jeroen/s2/src/FindCommand.cpp: In member function ‘virtual void FindOptions::Name(const char)’: /home/jeroen/s2/src/FindCommand.cpp:50:33: error: ‘strlen’ was not declared in this scope 50 | const char nameEnd = name + strlen(name); | ^~ /home/jeroen/s2/src/FindCommand.cpp:5:1: note: ‘strlen’ is defined in header ‘’; did you forget to ‘#include ’? 4 | #include +++ |+#include 5 | make[2]: [CMakeFiles/s2core.dir/build.make:102: CMakeFiles/s2core.dir/src/FindCommand.cpp.o] Error 1 make[1]: [CMakeFiles/Makefile2:134: CMakeFiles/s2core.dir/all] Error 2 make: *** [Makefile:130: all] Error 2

calum74 commented 2 years ago

I'll look into this. IIRC this is a work in progress so I cannot promise anything.

calum74 commented 2 years ago

I've tested this on OSX and Linux (Ubuntu). You can build with

make s2

which will just build the command line. Looks like the tests are horribly broken the last time I checked this in - sorry. This project is more or less abandoned so don't expect too much!

xandark commented 1 month ago

The tests have been fixed recently, so it builds just fine doing a regular make, no make s2 is necessary anymore, so this issue might be resolved.