search

calumk / editorjs-columns

115 stars 26 forks source link

Link inlineToolbar not working #3

Open foarsitter opened 2 years ago

foarsitter commented 2 years ago

Thanks for providing this amazing tool. It helps us to achieve a higher level of content creation of our users.

Enabling the inlineToolbar for the paragraph tool is not working for the link tool. Any clues how to solve this?

Here is a modified version of the example.html illustrating the problem: https://gist.github.com/foarsitter/ece006ffc97d41f5d2228a16f194b1ef

calumk commented 2 years ago

Thanks for providing this amazing tool. It helps us to achieve a higher level of content creation of our users.

Thanks!

Enabling the inlineToolbar for the paragraph tool is not working for the link tool. Any clues how to solve this? Here is a modified version of the example.html illustrating the problem: https://gist.github.com/foarsitter/ece006ffc97d41f5d2228a16f194b1ef

Hmm - This is strange. I see the problem, but i cant work out whats causing it... It seems to be the same issue for the standard paragraph tool, and works when its not in a column.

I suspect there is something going on here with the way editor.js clears / deals with toolboxes. - It might be that nesting it causes some issues, or that the two instances search for the toolbar globally in the dom etc....

Ill keep looking.

bekiroeztuerk commented 1 year ago

Hello @calumk ,

Do you have a solution for this? I have the same problem.

aacoelho commented 11 months ago

I'm experiencing the same issue. Any news about this?

sureshHARDIYA commented 10 months ago

https://github.com/calumk/editorjs-columns/assets/2022919/156c2307-daf3-4236-be12-4a5cf5e80769

I am having same issue. Has anyone found the solution to this? Interestingly, when you copy past article with links from somewhere and paste, it sustains the link.

calumk commented 10 months ago

Hello all - really sorry but no i never found a solution for this

when you copy past article with links from somewhere and paste, it sustains the link.

Yes, the issue is not with the data stored, it is probably related to having multiple instances of EditorJS in the same webpage. Maybe something like popups is stored globally

Tomnuyts commented 8 months ago

It's indeed true that this has to do with nesting editorjs instances. Check out this pull request for more information about this issue: https://github.com/codex-team/editor.js/pull/2581

calumk commented 8 months ago

Thankyou for finding this issue

If you can propose a solutionor pull request to solve it somehow then I am very happy to implement

Tomnuyts commented 8 months ago

Problem is this can only be fixed in editorjs itself. So I forked the editorjs repo and made the necessary changes in the file to get it working. Hopefully they will approve the pull request or provide a fix themselves soon, so that I can switch back to the original repo.

vFire commented 7 months ago

When the link is in columns, everything is works only except the popup window will hide imediately, so make it unavailable, are there any hack to view the popup?

vFire commented 7 months ago

Problem is this can only be fixed in editorjs itself. So I forked the editorjs repo and made the necessary changes in the file to get it working. Hopefully they will approve the pull request or provide a fix themselves soon, so that I can switch back to the original repo.

Are there any chance that help me on how to change in the fork of editorjs? Much appreciated.

calumk commented 7 months ago

When the link is in columns, everything is works only except the popup window will hide imediately, so make it unavailable, are there any hack to view the popup?

At the moment, I have no solution

I /think/ the fork at : https://github.com/loucass003/editor.js/tree/next will fix this. You could try to clone and build this fork to see - I have not done this yet.

vFire commented 7 months ago

I just found once click in the any column area will trigger all editorjs instances saving... Maybe this will prevent the link popup editing modal from visibility.

Tomnuyts commented 7 months ago

When the link is in columns, everything is works only except the popup window will hide imediately, so make it unavailable, are there any hack to view the popup?

At the moment, I have no solution

I /think/ the fork at : https://github.com/loucass003/editor.js/tree/next will fix this. You could try to clone and build this fork to see - I have not done this yet.

This fork does indeed fix the issue.

calumk commented 7 months ago

So then our best bet at the moment is to promote : https://github.com/codex-team/editor.js/pull/2581

calumk commented 7 months ago

Looks like there is some progress on https://github.com/codex-team/editor.js/pull/2581

Once it merges, i will test, make some updates, and push a new version

sureshHARDIYA commented 7 months ago

Depends on how soon PR owner makes requested changes

DinandN commented 1 month ago

Any news on this problem yet?

calumk commented 1 month ago

7 days ago there was some progress

https://github.com/codex-team/editor.js/pull/2780

Looks like we might finally have a solution in the next release of editorjs