cmd38 lab 11

[cmd16]

Lab 11

Homework 1 Followed:

• convert public instance variables to private
• obsolete gradle dependency Ignored:
• remove unused parameter ‘view’ in calculateResult - app crashes if I remove that parameter, presumably because an onClick method needs a view parameter
• missing support for Firebase app indexing - seems irrelevant
• AllowBackup - it’s fine if all data is backed up
• implied default locale in case conversion - only intend to use this at small scale (in one locale)

Homework 2 Followed:

• reorder imports
• condense some lines into single lines (in xml)
• url loader declaration can be final
• make classes package-private
• set importantForAutofill=“no” Ignored:
• deprecated API usage - I’m following the tutorial, not trying to learn an entirely new API
• missing support for Firebase app indexing - seems irrelevant
• AllowBackup - it’s fine if all data is backed up
• Attribute usesClearText traffic unused in older versions - that attribute is unimportant

Homework 3 Followed:

• adjust spacing
• collapse empty xml tag
• not annotated parameter overrides @NonNull parameter
• declaration can have final modifier
• fixed typos
• overdraw: painting regions more than once
• unused resources Ignored:
• missing constraints in Constraint - works fine without the constraints
• string literal in setText cannot be translated - setText won’t work with a string resource
• unused declaration - we were required to declare things that we weren’t required to implement
• declaration can have final modifier - same reason I ignored unused declaration
• make class package-private - seemed to make things crash?