search

calvin-cs262-fall2023-teamA / client

2 stars 0 forks source link

added pin icon on addpage and several other improvements #76

Closed harryg02 closed 10 months ago

Steven-McKelvey commented 10 months ago

Just merged this, but I don't know if you had pushed the changes you made yesterday (Selected Location -> "N/A", fix comment arrow being pushed off of the screen).

harryg02 commented 10 months ago

yes these fixes should all be there

From: StevenM-Calvin @.> Sent: Thursday, November 30, 2023 12:17 To: calvin-cs262-fall2023-teamA/client @.> Cc: Harry Gu @.>; Author @.> Subject: Re: [calvin-cs262-fall2023-teamA/client] added pin icon on addpage and several other improvements (PR #76)

Just merged this, but I don't know if you had pushed the changes you made yesterday (Selected Location -> "N/A", fix comment arrow being pushed off of the screen).

— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_calvin-2Dcs262-2Dfall2023-2DteamA_client_pull_76-23issuecomment-2D1834199660&d=DwMFaQ&c=4rZ6NPIETe-LE5i2KBR4rw&r=ub6PkGd9oOThfKt-RQYdkg&m=bS7wXgkRwGvBc-pRJBvCyKzpoAaQeZdHvet6F1JNMRoe-qhbS3wsByVCgP7Mxvlo&s=ZESRFKfI3CNusIhYeda4NDRcj_xgAFCbx1ES8jA1aao&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWPEA5SUWWUU6PJOFA25P53YHC5RBAVCNFSM6AAAAABAAEB55CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZUGE4TSNRWGA&d=DwMFaQ&c=4rZ6NPIETe-LE5i2KBR4rw&r=ub6PkGd9oOThfKt-RQYdkg&m=bS7wXgkRwGvBc-pRJBvCyKzpoAaQeZdHvet6F1JNMRoe-qhbS3wsByVCgP7Mxvlo&s=qymzsxQ-42MmgtMDzOgJfoYk1oaTZN_xpkYjpsCd0kk&e=. You are receiving this because you authored the thread.Message ID: @.***>

harryg02 commented 10 months ago

nevermind, i didn't commit, i just did that now

From: Harry Gu @.> Sent: Thursday, November 30, 2023 12:18 To: calvin-cs262-fall2023-teamA/client @.>; calvin-cs262-fall2023-teamA/client @.> Cc: Author @.> Subject: Re: [calvin-cs262-fall2023-teamA/client] added pin icon on addpage and several other improvements (PR #76)

yes these fixes should all be there

From: StevenM-Calvin @.> Sent: Thursday, November 30, 2023 12:17 To: calvin-cs262-fall2023-teamA/client @.> Cc: Harry Gu @.>; Author @.> Subject: Re: [calvin-cs262-fall2023-teamA/client] added pin icon on addpage and several other improvements (PR #76)

Just merged this, but I don't know if you had pushed the changes you made yesterday (Selected Location -> "N/A", fix comment arrow being pushed off of the screen).

— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_calvin-2Dcs262-2Dfall2023-2DteamA_client_pull_76-23issuecomment-2D1834199660&d=DwMFaQ&c=4rZ6NPIETe-LE5i2KBR4rw&r=ub6PkGd9oOThfKt-RQYdkg&m=bS7wXgkRwGvBc-pRJBvCyKzpoAaQeZdHvet6F1JNMRoe-qhbS3wsByVCgP7Mxvlo&s=ZESRFKfI3CNusIhYeda4NDRcj_xgAFCbx1ES8jA1aao&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWPEA5SUWWUU6PJOFA25P53YHC5RBAVCNFSM6AAAAABAAEB55CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZUGE4TSNRWGA&d=DwMFaQ&c=4rZ6NPIETe-LE5i2KBR4rw&r=ub6PkGd9oOThfKt-RQYdkg&m=bS7wXgkRwGvBc-pRJBvCyKzpoAaQeZdHvet6F1JNMRoe-qhbS3wsByVCgP7Mxvlo&s=qymzsxQ-42MmgtMDzOgJfoYk1oaTZN_xpkYjpsCd0kk&e=. You are receiving this because you authored the thread.Message ID: @.***>

Steven-McKelvey commented 10 months ago

nevermind, i didn't commit, i just did that now

If you make another pull request for it, I can approve it.