calvinaquino / LNReader-Android

Light novel reader for android test project collab
Apache License 2.0
119 stars 36 forks source link

opening quotes are not visible #139

Closed Mithgol closed 10 years ago

Mithgol commented 10 years ago

The character (Unicode U+201F) is used as the opening quote in OniAi: Volume 2 Chapter 4.1 and in other chapters of that volume.

Unfortunately, BakaReader EX does not seem to display that quote on my HTC One, though the space for that character seems to be reserved:

(OniAi screenshot)

Android 4.4.2.

Nandaka commented 10 years ago

That's weird, cos no string manipulation to get the content except to replace the img src path...

I suspect because of font? need to check on DB

Nandaka commented 10 years ago

Checked on my phone (CM10.2) and my friend LG G2 (KitKat), and it shows properly. I think it is because of the font.

Nandaka commented 10 years ago

Crap, I open the wrong chapter. Volume 1 is OK, only volume 2 is wrong.

Checked the DB, quotes is properly saved. so I thinks the problem is with android itself? I tried to save the page to html page and open it with various app:

Mithgol commented 10 years ago

Could you implement some workaround, such as using some specific font for U+201F characters?

(Also could you reopen this issue now?)

Nandaka commented 10 years ago

I'm checking if using different font will resolve it or not, other than that is by using char replacement for the quotes directly to DB.

Nandaka commented 10 years ago

checked the font in the DroidSansFallback, they only have

I prefer to change the actual content in BakaTsuki, rather than do some string manipulation on the app.

EDIT: or change the default font for the content to serif (it shows the quotation mark) try to save the css: http://pastebin.com/nAyptSkC and set it in Settings -> Reading Layout -> Group 2 -> CSS Layout -> Use Custom CSS = true, and set the path.

Mithgol commented 10 years ago

I prefer to change the actual content in BakaTsuki, rather than do some string manipulation on the app.

I guess that's what I am going to do; I believe the translator should have refrained from using Unicode U+201F instead of Unicode U+201C .

Mithgol commented 10 years ago

For the record, here's the JavaScript code I wrote to make replacements on edit pages:

$('textarea').val( $('textarea').val().replace(/‟/g, '“') )

(At first I tried making all the replacements manually, but quickly felt the necessity of some automation.)

Nandaka commented 10 years ago

btw, I've added a function to change the typeface in Settings -> Reading Layout -> CSS Layout for both Heading and Content (basically externalize the css). Valid selection are, sans-serif, serif, and monospace.

The serif one able to show the U+201F

Mithgol commented 10 years ago

Thanks (though I hope I won't have to use it).

QusaTalma commented 10 years ago

The chapter/s in question are ones that I posted. Going forward I will use U+201C rather than U+201F. Apologies for the trouble.

--QusaTalma

Mithgol commented 10 years ago

@QusaTalma Thanks for the chapters!