search

calvinaquino / LNReader-Android

Light novel reader for android test project collab
Apache License 2.0
119 stars 36 forks source link

Some weird logic missed out, might be the reason for the crashes #171

Closed yaminorito closed 9 years ago

yaminorito commented 9 years ago

Probably due to the introduction of holder and convertview in BookModelAdapter, the text color of the volumes changes on every scroll change on certain circumstances, although it didn't crash on my 4.2.2 or 4.4.2.

Sample(Campione!): Might need to look a little bit closer to see the difference in color(I did).

Before opening Volume 17: screenshot_2014-11-14-20-36-29 screenshot_2014-11-14-20-36-49

After opening Volume 17 and scrolling up: screenshot_2014-11-14-20-37-06

Notice that the Chapters 16 and 17 of Volume 16 became pink colored despite being white previously.

EDIT:

Rakudai Kishi no Eiyuutan - when I scroll down after expanding a Volume makes BakaReaderEX crash.

Nandaka commented 9 years ago

not crashing in my device (after applying the patch)

xuanduc987 commented 9 years ago

The patch only fix the wrong color thing. No crashing on my device too.

yaminorito commented 9 years ago

Working now, thanks. And no more crashes too, that did it. I'm not so sure about others who had crashes though, but probably no more for them too. I have 4.4.2, 4.2.2 and 4.0.4, and the two older had crashes before patch, weird that 4.4.2 didn't, since others that had crashes had that version if I remember correctly.