calvinaquino / LNReader-Android

Light novel reader for android test project collab
Apache License 2.0
119 stars 36 forks source link

Full screen not working in conjunction with previous/next buttons, Full screen mode not consistant. #199

Closed john34404 closed 9 years ago

john34404 commented 9 years ago

The new UI for the app is confusing/not fully working. Ok so I want my chapters displayed in full screen mode with the previous/next buttons at the top. But I cannot get the chapters to consistently be in full screen mode.

It changes from far zoomed out mode to full screen mode only after I go into the settings. I need to do this every time for every chapter. I think its due to the newest android update. V:5.0.1

Is this a bug? Or do I need step by step instructions?

What I get without full screen mode on (and with full screen mode on after advancing to next chapter): screenshot_2015-06-22-05-11-18 2

What I get with full screen mode on: screenshot_2015-06-22-05-11-40 1

What I want/expect: Received this result by turning full screen mode on, going to different chapter, turning it off than going back to previous chapter. screenshot_2015-06-22-05-11-25 1

john34404 commented 9 years ago

The phone is a Samsung galaxy s4 active. Running the really bad (because I accidently hit the update button) most current UI for the phone.

Nandaka commented 9 years ago

There is a bug on the fullscreen mode for 1.1.31. It should not be tied to the chapter setting (except the zoom level).

But fyi, in the fullscreen mode (or immersive mode if you are using kitkat+), it should hide the action bar.

john34404 commented 9 years ago

I have always used the bottom picture version on my device. If the bottom version was a glitch than it would be a nice setting. If it is suppose to be like the bottom version on certain settings than what are the settings?

Nandaka commented 9 years ago

Should be like number 3 in this page: https://developer.android.com/training/system-ui/immersive.html

Mithgol commented 9 years ago

I'm on HTC One M9 (running Android 5.0.2, which is Lollipop, i.e. should be newer than KitKat and support immersiveness), a checkbox in on “Use Fullscreen” in “Preferences” → “Reading Layout” → “Group 2”, but the action bar does not go away.

Also, while notification bar (topmost) and software buttons bar (bottommost) disappear in fullscreen mode, the application does not seem to claim their area and it remains solid dark gray filled.

I cannot provide a screenshot because Power+Home combination requires software “Home” button that is not visible in fullscreen mode.

Nandaka commented 9 years ago

Try https://github.com/calvinaquino/LNReader-Android/releases/tag/1.1.32-beta2

bliu886 commented 9 years ago

In the beta, it doesn't seem to work on my device, running Android 5.0.2. It is how Mithgol states dark grey bars where the notification bar and the software button bar are located:

screenshot_2015-07-04-21-33-57 1

Nandaka commented 9 years ago

Try: https://github.com/calvinaquino/LNReader-Android/releases/tag/1.1.32-beta3

Tested in emulator (API10/Gingerbread) device-2015-07-05-135406

On Samsung Galaxy Note (API21/Lollipop) device-2015-07-05-135719

jeremiejig commented 9 years ago

Hello,

The playstore version is now 1.1.32, and while it is pretty great with all the fix, some issues appear and remain. Pretty much all the issue has already been raised.

I'm expecting the menu button to be at the bottom with the system nav bar like in this screenshot :

screenshot_2015-07-09-12-54-26

While i'm there, here is my immersive fullscreen mode. The app is running on a Xperia Z3 running lollipop 5.0.2.

screenshot_2015-07-09-12-09-44

I wish you the good luck with all the fixes.

Nandaka commented 9 years ago

the 1st picture might be impossible, as that menu overflow icon only will visible if the application is targeting android 2.3.x

maybe I need to add virtual button to trigger menu pop-up.

jeremiejig commented 9 years ago
Mithgol commented 9 years ago

Upgraded to 1.1.32 (201507090).

On my HTC One M9, the action bar and the notification bar (on the top) both disappear just fine. (Except that action bar can't be displayed again, as @jeremiejig have previously noticed.) However, while the phone's navigational buttons (on the bottom) also disappear, the application does not seem to claim their area and it remains solid dark gray filled.

I have found a workaround:

Wolfpup67 commented 9 years ago

I'm also seeing this issue even with the current released version on my Samsung Galaxy Prevail LTE running Android 4.4.4. I am including a screen shot form my phone. screenshot_2015-07-09-17-15-00 1

Nandaka commented 9 years ago

Chrome behaviour?

You means show the toolbar when the window have focus (and disappear after few seconds)?

unclaimed area

Maybe I need to add more flag (SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN / SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION )?

I'm using Lollipop (CM12.1) and it shows correctly...

Nandaka commented 9 years ago

Try https://github.com/calvinaquino/LNReader-Android/releases/tag/1.1.33-beta1

tap to show the Toolbar, and it should auto hide after 4s.

jeremiejig commented 9 years ago

When I say chrome behavior, I mean the android chrome app. When you slide to the bottom of the page the address bar will collapse upside (hope you see what I mean), and when you need the address bar, or simply when the user slide to the top, the address bar reappear.

Nandaka commented 9 years ago

I think it is better to show the toolbar when user is touch the content (not scrolling) and auto hide after few seconds. I don't want to scroll up just to show the toolbar and slide down to hide it :smile:

jeremiejig commented 9 years ago

Well yeah, might depends on the person.

I tested 1.1.33-beta1 on my xperia, setting aside that I find the apparition a bit spooky, I do have a feedback :

Well apart that I find it pretty weird with the bookmark 📑 feature, I find this behavior pretty convenient. ☺

On a side note, the android nav bar at the bottom now correctly hide its icons, but still do not reclaim the empty space.

Nandaka commented 9 years ago

what is your android version?

It should hide the nav bar on API19/KITKAT https://developer.android.com/reference/android/view/View.html#SYSTEM_UI_FLAG_HIDE_NAVIGATION https://developer.android.com/reference/android/view/View.html#SYSTEM_UI_FLAG_FULLSCREEN

Refer to https://github.com/calvinaquino/LNReader-Android/blob/master/app/src/main/java/com/erakk/lnreader/helper/DisplayNovelContentUIHelper.java#L156

jeremiejig commented 9 years ago

Well I'm on android 5.0.2 lollipop,

I'm seeing the use of WindowManager.LayoutParams.FLAG_FULLSCREEN https://github.com/calvinaquino/LNReader-Android/blob/master/app/src/main/java/com/erakk/lnreader/helper/DisplayNovelContentUIHelper.java#L155

I'm wondering if it is interfering with the system_ui_flag while there isn't anything in the doc that said so.

Another point : when the user perform an action to display the navigation bar again (like resuming the app) the navigation bar won't rehide itself (while the status bar rehide without problem, thanks to the immersive flag I think). Workaround for now : tap the screen, to display the action bar, and the timer will rehide everything.

Finally : Now that I'm aware of the flag SYSTEM_UI_FLAG_LAYOUT_* you might want to set these when the user has activate the fullscreen. I think it will remove the spookiness I feel when the action bar show/hide (The redrawing taking into account the action bar I think without).

Hope I'm readable.

Nandaka commented 9 years ago

implement timer to automatically hide after 10s.

another way is by fast scrolling either direction will force the action bar to be hidden