search

calvinaquino / LNReader-Android

Light novel reader for android test project collab
Apache License 2.0
119 stars 36 forks source link

External chapters are marked as downloaded when tried to download via context menu #221

Closed HYBRID-BEING closed 8 years ago

HYBRID-BEING commented 8 years ago

Download All Chapters button ignores external chapters and there doesn't seem to be any option to change that. I have to resort to downloading volumes one by one. UPD: actually, disregard that, i got it wrong. Download All Chapters silently ignores external chapters, and volume and chapter download marks external chapters as downloaded, yet they are actually not and only get downloaded after opening them (if internet connection is up).

Nandaka commented 8 years ago

that is by design, as I don't know how to download the external link with all the related resources (e.g. css, js, images, etc).

The external pages only saved when you load it manually using API provided by WebView.

HYBRID-BEING commented 8 years ago

Oh well, can't be helped then. In this case, perhaps, chapters should not be marked as downloaded, when trying to download them or whole volume. Also, might be nice if popup mentioned that external chapters were skipped (if present).

Nandaka commented 8 years ago

welp, that's a bug then. I'll fix it so it will skip the external chapter.