calvinaquino / LNReader-Android

Light novel reader for android test project collab
Apache License 2.0
120 stars 36 forks source link

Cover image won't load in novel list except downloaded ones #277

Open takase1121 opened 5 years ago

Nandaka commented 5 years ago

Have you tried to do Download All Info from the overflow menu?

masterupc commented 5 years ago

Images don't download at all... even with Download All Info from the overflow menu... Not only cover images... all the images!

Nandaka commented 5 years ago

Is the novel info loaded when you open the novel? Do you give the storage permission or do you have free space on the phone?

What is the path used for storing the images? You can check it from Settings -> Storage -> Image Save Location.

takase1121 commented 5 years ago

tried the Download All Info and it worked. Thanks!

masterupc commented 5 years ago

@Nandaka I've had to grant manually storage permission to the app. That's something you should have set in the manifest of the project as it never asked it for permissions. If you're targeting API 26 or above then you MUST let the app ask for permissions. Well, it works fine after that.

Nandaka commented 5 years ago

weird, I have declare it in the manifest. https://github.com/calvinaquino/LNReader-Android/blob/master/app/src/main/AndroidManifest.xml#L7

Nandaka commented 5 years ago

modified the code so it will ask upon runtime too.

masterupc commented 5 years ago

@Nandaka Now that everything is fine... can you add an option for the default novel storage? The internal storage is fine but having an SD, it can be great if it can be migrated there... it's just an idea (so it doesn't eat, in my case, 2GB of storage... xD).