calvinckho / capacitor-jitsi-meet

This plugin is used to make video calls using Jitsi video platform (https://meet.jit.si) on iOS and Android using Ionic Capacitor.
85 stars 40 forks source link

Nothing happens when conference is terminated #75

Closed gianlucapinna83 closed 2 years ago

gianlucapinna83 commented 2 years ago

Hi @calvinckho , first of all I would say "thanks!" for this amazing plugin.

Here my issue:

I use your plugin within a Ionic app, to let non-moderator users join to an already existing room. When the room is destroyed or terminated by a moderator, on the ionic app the room is still alive and I see a spinning symbol.

To do this I use this jitsi plugin: https://gist.github.com/shawnchin/2eafb7ed25b4c874882c5f61195851c1

Looking for a bit, I think that it would be great if you could listen another broadcast event: CONFERENCE_TERMINATED alike of other events, like CONFERENCE_JOINED or PARTICIPANT_LEFT.

I'm not sure this is the solution, but I hope so.

Thanks a lot!

calvinckho commented 2 years ago

@gianlucapinna83 I have added the code to listen to CONFERENCE_TERMINATED in android and conferenceTerminated in iOS.

You can test it by installing this branch: npm i git+ssh://git@github.com/calvinckho/capacitor-jitsi-meet#terminate-conference

It should listen to those events and force all participants to leave a conference.

gianlucapinna83 commented 2 years ago

@calvinckho I've tested and it works perfectly!

Thank you!

calvinckho commented 2 years ago

That's great news. Please test it for a few weeks. If there is no issue, I can merge it with the main branch and release it on npm in the next release.