search

calvinmetcalf / crypto-pouch

plugin for encrypted pouchdb/couchdb databases
MIT License
243 stars 43 forks source link

refactor #26

Closed calvinmetcalf closed 8 years ago

calvinmetcalf commented 8 years ago

refactors to not asyncly set up encrypting, blocked by nolanlawson/transform-pouch#19

gr2m commented 8 years ago

nolanlawson/transform-pouch#19 was now merged via https://github.com/nolanlawson/transform-pouch/pull/24

gr2m commented 8 years ago

updated it to latest transform-pouch and fixed a few minors in https://github.com/calvinmetcalf/crypto-pouch/pull/28

nolanlawson commented 8 years ago

LGTM, except I'm kinda surprised there were so many test cases removed.

gr2m commented 8 years ago

Thanks Nolan. I’ll have another look at the tests

gr2m commented 8 years ago

@nolanlawson the reason why so many tests were removed is that the 2nd argument db.crypto(secret, diffieHellman) was removed, now only db.crypto(secret) is supported. I don’t even know what that is :)

I’ve cleaned up the commits to separate refactoring from the breaking change.

nolanlawson commented 8 years ago

Ah I see, so it's a breaking change since part of the API was removed. Looks reasonable, +1.

gr2m commented 8 years ago

this was merged via #29