search

calvinmetcalf / crypto-pouch

plugin for encrypted pouchdb/couchdb databases
MIT License
243 stars 43 forks source link

options.ignore #29

Closed gr2m closed 8 years ago

gr2m commented 8 years ago

follow up for https://github.com/calvinmetcalf/crypto-pouch/pull/25, based on https://github.com/calvinmetcalf/crypto-pouch/pull/26

xMartin commented 8 years ago

Works for me.

As the option is called "ignore" we should probably change the title of this issue to avoid confusion.

As I understand it, the {ignore: '_attachments'} option is currently required if you're not 100% sure there will never be attachments in your documents. With this option set, db.putAttachment / db.getAttachment are working for me, so the note in the README is misleading.

calvinmetcalf commented 8 years ago

I don't think this was built on master

gr2m commented 8 years ago

done updating

calvinmetcalf commented 8 years ago

I just got back from vacation and am digging out so I'll try to get to this sometime today or tommorow

calvinmetcalf commented 8 years ago

few nits otherwise looks good

calvinmetcalf commented 8 years ago

looking good, feel free to squash and merge

gr2m commented 8 years ago

I’ve added and pushed a build commit, too (7feae75). I think ít’s ready for a new release