search

calvinmetcalf / fileGDB.js

parse a file GDB
http://calvinmetcalf.github.io/fileGDB.js
MIT License
68 stars 10 forks source link

Return a promise on a buffer passed in + update gruntfile #6

Closed sainsb closed 9 years ago

sainsb commented 9 years ago

When passing in a buffer, a promise wasn't being returned...not sure exactly how you want to implement this...but this got me over my hurdle....also...outdated gruntfile. more PRs coming soon.

calvinmetcalf commented 9 years ago

Iv been moving away from grunt and towards npm scripts, see the recent update to shapefile-js

On Thu, Jul 30, 2015, 8:36 PM Ben Sainsbury notifications@github.com wrote:

When passing in a buffer, a promise wasn't being returned...not sure exactly how you want to implement this...but this got me over my hurdle....also...outdated gruntfile.

more PRs coming soon.

You can view, comment on, or merge this pull request online at:

https://github.com/calvinmetcalf/fileGDB.js/pull/6 Commit Summary

  • Return a promise on a buffer passed in + update gruntfile

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/calvinmetcalf/fileGDB.js/pull/6.

calvinmetcalf commented 9 years ago

(otherwise your pull looks good so far)

On Thu, Jul 30, 2015, 8:52 PM Calvin Metcalf calvin.metcalf@gmail.com wrote:

Iv been moving away from grunt and towards npm scripts, see the recent update to shapefile-js

On Thu, Jul 30, 2015, 8:36 PM Ben Sainsbury notifications@github.com wrote:

When passing in a buffer, a promise wasn't being returned...not sure exactly how you want to implement this...but this got me over my hurdle....also...outdated gruntfile.

more PRs coming soon.

You can view, comment on, or merge this pull request online at:

https://github.com/calvinmetcalf/fileGDB.js/pull/6 Commit Summary

  • Return a promise on a buffer passed in + update gruntfile

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/calvinmetcalf/fileGDB.js/pull/6.

sainsb commented 9 years ago

Hmmm....ok. After creating the pull request I realized that the Browserify upgrade in the gruntfile somehow destroyed the fgdb namespace and so...can't ... use... will explore the npm scripts approach...seems simpler. I guess...

calvinmetcalf commented 9 years ago

so I'm merging this in and looking through the api, it was set up to only be async if you gave it a path, and be sync if you gave it data, obviously this is a little confusing so this will probably be a major version change, also don't worry about grunt I can fix the build system (and any additional pulls are about to be bit rotted due to a massive cleanup of the formatting)