search

calvinmetcalf / rollup-plugin-node-builtins

138 stars 40 forks source link

Add arch to exported os methods #44

Open garajo opened 6 years ago

garajo commented 6 years ago

I'm using a library which depends on package xhr2 and was getting an error 

Uncaught TypeError: os.arch is not a function

which was getting invoked here, https://github.com/pwnall/node-xhr2/blob/4a2c826f60342501dc51e708882748840ba5dc6b/src/001-xml_http_request.coffee#L395

wouterlanduydt commented 5 years ago

Running into this as well. Anything preventing this PR to be merged?

mrmartineau commented 5 years ago

@calvinmetcalf any news on this PR?

Matthew-Smith commented 5 years ago

Encountering this as well

akauppi commented 4 years ago

Please compare with https://github.com/calvinmetcalf/rollup-plugin-node-builtins/pull/52/files - duplicate but slightly different.