calvinmetcalf
commented
3 years ago ok so the deal is that you can have one or more shp or json files in the csv and any json file will be parsed and put in the output, now it is a bit weird that having any json file in addition to a .shp causes you to get an array of files back instead of just the geojson. But yes in generally we don't actually check if the json are sent is actually valid geojson (i guess it could be esrijson).
ok yeah it's a bit weird but at this point it would be breaking change to fix it so sorry.
yaegel
When passing a file into the shp function this is my basic understanding:
shp(file).then( (geojson) => { // do geojson processing here}, (error) => { // handle errors with grace here } )
but when I pass a zip file containing random json (not geojson) files - it still falls into the (geojson) => block.
It seems to me that if the parsing of the zip into a geojson object fails to produce valid geojson object, the result should fall into the (error) => block.
Otherwise, I have to check for the existence of the features property in the success block and handle errors in two places.