search

calvinmetcalf / shapefile-js

Convert a Shapefile to GeoJSON. Not many caveats.
http://calvinmetcalf.github.io/shapefile-js/
715 stars 228 forks source link

Conflict with Prototype 1.6.0.3 #82

Closed robisaks closed 6 years ago

robisaks commented 6 years ago

Kind of odd, but if the page has Prototype version 1.6.0.3, shp.js to load fails with "Uncaught WGS84"

shp.js:14153 Uncaught WGS84 Projection$1.callback @ shp.js:14153 Projection$1 @ shp.js:14163 Projection$1 @ shp.js:14149 (anonymous) @ shp.js:14629 (anonymous) @ shp.js:12805 54 @ shp.js:12808 s @ shp.js:1 (anonymous) @ shp.js:1 (anonymous) @ shp.js:22268 58../binaryajax @ shp.js:22422 s @ shp.js:1 e @ shp.js:1 (anonymous) @ shp.js:1 (anonymous) @ shp.js:1 (anonymous) @ shp.js:1

line where the failure is happening. https://github.com/calvinmetcalf/shapefile-js/blob/gh-pages/dist/shp.js#L14153

Chrome Version 60.0.3112.90 (Official Build) (64-bit)

I'll be coding around it, but thought I'd post in case anyone else encounters this. I only tested 1.6.0.3, so it might not be an issue on newer versions.

calvinmetcalf commented 6 years ago

Does prototype per chance overwrite some of the array prototype methods?

On Tue, Aug 15, 2017, 5:41 PM Rob notifications@github.com wrote:

Kind of odd, but if the page has Prototype version 1.6.0.3, shp.js to load fails with "Uncaught WGS84"

shp.js:14153 Uncaught WGS84 Projection$1.callback @ shp.js:14153 Projection$1 @ shp.js:14163 Projection$1 @ shp.js:14149 (anonymous) @ shp.js:14629 (anonymous) @ shp.js:12805 54 @ shp.js:12808 s @ shp.js:1 (anonymous) @ shp.js:1 (anonymous) @ shp.js:22268 58../binaryajax @ shp.js:22422 s @ shp.js:1 e @ shp.js:1 (anonymous) @ shp.js:1 (anonymous) @ shp.js:1 (anonymous) @ shp.js:1

line where the failure is happening.

https://github.com/calvinmetcalf/shapefile-js/blob/gh-pages/dist/shp.js#L14153

Chrome Version 60.0.3112.90 (Official Build) (64-bit)

I'll be coding around it, but thought I'd post in case anyone else encounters this. I only tested 1.6.0.3, so it might not be an issue on newer versions.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/calvinmetcalf/shapefile-js/issues/82, or mute the thread https://github.com/notifications/unsubscribe-auth/ABE4n2EtI80Nufsq3X0OYvzRg5h4P5qYks5sYhCggaJpZM4O4Jvp .

robisaks commented 6 years ago

Yea, I'm sure it does. It overrides a lot of core js. It's pretty annoying to deal with.

calvinmetcalf commented 6 years ago

I think you may have answered your own question ¯_(ツ)_/¯

robisaks commented 6 years ago

Yup, I was just posting in case anyone else encountered it.