calvinmetcalf / shapefile-js

Convert a Shapefile to GeoJSON. Not many caveats.
http://calvinmetcalf.github.io/shapefile-js/
MIT License
735 stars 230 forks source link

Importing shapefiles with projection is broken #85

Closed senritsu closed 7 years ago

senritsu commented 7 years ago

Since the update of proj4 to use default exports this library doesn't work anymore when importing shape files in a zip with included projection file or a separate projection string.

The imports of proj4 for this library would need to be changed to either use ES6 module imports, or to require('proj4').default, otherwise what it imports isn't a function.

estaub commented 7 years ago

Maybe this is the fix for https://github.com/calvinmetcalf/shapefile-js/issues/75?

senritsu commented 7 years ago

@estaub seems very likely

calvinmetcalf commented 7 years ago

84 should fix this I should be able to publish this latter today

calvinmetcalf commented 7 years ago

v3.4.1 is published

estaub commented 7 years ago

Confirmed as fix for #75.