search

calvinmetcalf / topojson.py

Topojson ported to python
Other
92 stars 37 forks source link

Converting code to idiomatic Python #1

Open scardine opened 11 years ago

scardine commented 11 years ago

Nice work, man! I was looking for the quantization algorithm (Mike's source is way beyond my javascript wizardry level).

The code still smells like javascript. :-)

I want to help converting this to more idiomatic Python, can I send PR's?

calvinmetcalf commented 11 years ago

that would be extremely helpful I'm primarily a javascripter myself, hence how I was able to untangle the code. Also we need unit tests, what do the python kids use for that?

calvinmetcalf commented 11 years ago

fyi I've pushed to master since you forked it.

scardine commented 11 years ago

Hi Calvin!

I'm writing tests with PyUnit.