search

calvinmetcalf / topojson.py

Topojson ported to python
Other
92 stars 37 forks source link

fix geojson package clash #23

Closed Pangstar closed 6 years ago

Pangstar commented 7 years ago

Great piece of work!

I have currently sub moduled this repo however I am getting a package clash. Could you add "." when referencing internal folders in your "from" statements.

specifically for geojson in the root init.py (making it from .geojson import geojson) geojson/init.py (making it from .conversion import conversion) geojson/conversion.py (making it from .geojson import from_topo)

Thanks!

calvinmetcalf commented 7 years ago

pull requests accepted

On Fri, Apr 14, 2017 at 7:58 AM Pang notifications@github.com wrote:

Great piece of work!

I have currently sub moduled this repo however I am getting a package clash. Could you add "." when referencing internal folders in your "from" statements.

specifically for geojson in the root init.py (making it from .geojson import geojson) geojson/init.py (making it from .conversion import conversion) geojson/conversion.py (making it from .geojson import from_topo)

Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/calvinmetcalf/topojson.py/issues/23, or mute the thread https://github.com/notifications/unsubscribe-auth/ABE4n8Pjq0kvDo9T9tQs58SVNt6cn8Ayks5rv19JgaJpZM4M9sJi .

Pangstar commented 7 years ago

Permissions are denied - can't make a pull request

calvinmetcalf commented 7 years ago

@Pangstar try forking it first

Pangstar commented 7 years ago

Thanks - exactly the problem.

Casyfill commented 6 years ago

fixed via #24?