calvinmetcalf / topojson.py

Topojson ported to python
Other
92 stars 37 forks source link

flake8 highlights multiple issues #34

Closed Casyfill closed 6 years ago

Casyfill commented 6 years ago

below:

./__init__.py:1:1: F401 'topojson.topojson' imported but unused
./__init__.py:2:1: F401 '.geojson.geojson' imported but unused
./__init__.py:2:29: W292 no newline at end of file
./setup.py:15:80: E501 line too long (88 > 79 characters)
./topojson/simplify.py:79:80: E501 line too long (85 > 79 characters)
./topojson/simplify.py:133:26: W601 .has_key() is deprecated, use 'in'
./topojson/simplify.py:135:31: F821 undefined name 'geometry'
./topojson/clockwise.py:20:80: E501 line too long (80 > 79 characters)
./topojson/coordinatesystems.py:32:9: E731 do not assign a lambda expression, use a def
./topojson/coordinatesystems.py:41:80: E501 line too long (81 > 79 characters)
./topojson/coordinatesystems.py:42:80: E501 line too long (83 > 79 characters)
./topojson/coordinatesystems.py:62:80: E501 line too long (80 > 79 characters)
./topojson/coordinatesystems.py:78:80: E501 line too long (84 > 79 characters)
./topojson/coordinatesystems.py:79:80: E501 line too long (83 > 79 characters)
./topojson/coordinatesystems.py:80:80: E501 line too long (81 > 79 characters)
./topojson/coordinatesystems.py:100:80: E501 line too long (93 > 79 characters)
./topojson/coordinatesystems.py:106:80: E501 line too long (86 > 79 characters)
./topojson/coordinatesystems.py:130:80: E501 line too long (85 > 79 characters)
./topojson/line.py:45:80: E501 line too long (83 > 79 characters)
./topojson/line.py:90:43: E721 do not compare types, use 'isinstance()'
./topojson/conversion.py:18:80: E501 line too long (85 > 79 characters)
./topojson/__init__.py:1:1: F401 '.conversion.convert as topojson' imported but unused
./topojson/utils.py:11:1: E731 do not assign a lambda expression, use a def
./topojson/mytypes.py:52:16: E711 comparison to None should be 'if cond is None:'
./topojson/mytypes.py:67:26: E711 comparison to None should be 'if cond is not None:'
./topojson/topology.py:8:1: F401 '.clockwise.Clock' imported but unused
./topojson/topology.py:9:1: F401 'decimal.Decimal' imported but unused
./topojson/topology.py:29:5: E731 do not assign a lambda expression, use a def
./topojson/topology.py:85:5: F841 local variable 'emax' is assigned to but never used
./topojson/topology.py:87:5: E301 expected 1 blank line, found 0
./topojson/topology.py:91:20: E713 test for membership should be 'not in'
./topojson/topology.py:94:5: F841 local variable 'fcInst' is assigned to but never used
./topojson/topology.py:95:5: E731 do not assign a lambda expression, use a def
./topojson/topology.py:97:5: E301 expected 1 blank line, found 0
./topojson/topology.py:100:36: E711 comparison to None should be 'if cond is None:'
./topojson/topology.py:110:80: E501 line too long (86 > 79 characters)
./topojson/topology.py:120:80: E501 line too long (82 > 79 characters)
./topojson/topology.py:134:25: E711 comparison to None should be 'if cond is None:'
./topojson/topology.py:139:31: E711 comparison to None should be 'if cond is None:'
./topojson/topology.py:146:80: E501 line too long (80 > 79 characters)
./topojson/stitchpoles.py:7:22: E721 do not compare types, use 'isinstance()'
./topojson/stitchpoles.py:8:9: F841 local variable 'verbose' is assigned to but never used
./topojson/hashtable.py:9:24: E721 do not compare types, use 'isinstance()'
./topojson/geojson/conversion.py:8:60: F821 undefined name 'unicode'
./topojson/geojson/conversion.py:12:31: F821 undefined name 'file'
./topojson/geojson/conversion.py:17:56: F821 undefined name 'unicode'
./topojson/geojson/conversion.py:20:30: F821 undefined name 'file'
./topojson/geojson/geojson.py:92:63: F821 undefined name 'coordinates'
./topojson/geojson/geojson.py:96:73: F821 undefined name 'coordinates'
./topojson/geojson/geojson.py:96:80: E501 line too long (86 > 79 characters)
./topojson/geojson/geojson.py:110:80: E501 line too long (84 > 79 characters)
./topojson/tests/topojson_test.py:14:80: E501 line too long (112 > 79 characters)
./topojson/tests/topojson_test.py:20:80: E501 line too long (80 > 79 characters)