search

calvn / chocolatey-consul

Chocolatey package for Consul
4 stars 27 forks source link

Patch extra args #3

Closed calvn closed 7 years ago

calvn commented 7 years ago

@anguswilliams @arledesma @123BLiN please review these changes.

@arledesma added $packageParameters, but it wasn't quite the way we would want to use it. Originally, the install would parse each of the params in a very specific way (matched by the regex), and would then set those to local environment variables which could be evaluated during the install. This makes sense for the example in the docs, but that regex wouldn't work for consul's arguments.

I chose to go with @123BLiN's PR changes in the old repo, so props goes to him.

arledesma commented 7 years ago

:+1:

calvn commented 7 years ago

0.7.4.1 is pending release from chocolatey. Once that's available, feel free to let me know if there are problems with it. If everything looks good, I'll proceed with releasing 0.7.5. Thanks guys!