search

calvn / chocolatey-consul

Chocolatey package for Consul
4 stars 27 forks source link

Provide parameter for installing the Consul agent service in client mode. #4

Closed JonPaz closed 7 years ago

JonPaz commented 7 years ago

In the current master branch, the Consul agent is always installed as a server. This change allows for Consul to be configured as either a client or server (default) instance based on an (optional) 'consulMode' parameter. Additionally, any supplied parameters will now get echo'd to the host so that it is easier to monitor what is going on.

To install the agent as a client: choco install consul -params "consulMode=client" To install the agent as a server: choco install consul

JonPaz commented 7 years ago

I probably should have added in the PR text that the same effect can be accomplished with the current code by setting the 'extraArgs' variable to "", however I felt that it would be preferable for usability to have an explicit parameter.

calvn commented 7 years ago

@JonPaz it seems that you didn't pull from master since the last release (0.7.4.1). extraArgs is no longer a thing, so you can pass the -server flag during cinst consul as part of the -params.

https://github.com/calvn/chocolatey-consul/blob/0.7.4.1/tools/chocolateyInstall.ps1#L12

JonPaz commented 7 years ago

Hi there Calvin and thanks for your e-mail, apologies for the slow reply!

I've now updated to 0.7.45 and it works a treat - thanks for all of your efforts in getting Consul to be a Windows service.

Cheers,

Jon.

On 19 February 2017 at 19:23, Calvin Leung Huang notifications@github.com wrote:

@JonPaz https://github.com/JonPaz it seems that you didn't pull from master since the last release (0.7.4.1). extraArgs is no longer a thing, so you can pass the -server flag during cinst consul as part of the -params.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/calvn/chocolatey-consul/pull/4#issuecomment-280941605, or mute the thread https://github.com/notifications/unsubscribe-auth/AF1anlhMl0EOUtNCRMQg3FrO4D0AH9Yaks5reJa9gaJpZM4MFdnm .