search

calxibe / StorjMonitor

Node.js script for publishing data from local Storj nodes to Storjstat.com
15 stars 14 forks source link

Ignore zero responseTime #14

Open dugwood opened 6 years ago

dugwood commented 6 years ago

Hello,

Not sure where to post this, but as there's no contact page on storjstat.com, here's my request: on storjstat.com the minimum responseTime is either 0 or 1 ms. Which can't be achieve :-)

I think the issue is to keep 0 as a valid value. In the last days, I created some nodes, and responseTime was either missing or returning 0, and that's a bug in the storj API. After creating those nodes on the next day, I ended up on the default 10000, which is declining as days go by.

So the graph is misleading: it should be around 50 or 100ms for the best node I think. Can you fix it?

Thanks for the monitor :-) Yvan.

calxibe commented 6 years ago

I believe we can just remove the feature, because the responseTime will always be the lowest i set. Here is a copy of stored today with grouping on responseTime: https://pastebin.com/GMbAs2gf

dugwood commented 6 years ago

Thanks for the data. Clearly, the group of 0ms is to be ignored. Then that would show 1ms... so perhaps a good idea would be to create a 10 percentile. That would give a rough idea of the best 10%, that are under XXXms. As your data is already ordered, the percentile should be easy to compute.