Closed sdesbure closed 6 years ago
Already merged your first pull request #20 👍 Feel free to implement the other solutions as well. I will rework the install routine in the meantime!
I've proposed a pull request for the Dockerfile. I'll see later for the "config.json" part :)
today in the code (https://github.com/calxibe/StorjMonitor/blob/master/storjMonitor.js#L29), the connection assumes that:
As I'm using oreandawe/strojshare-cli container, the daemon is not on the same host.
Therefore, it would be good to make variables like for token:
it would also be awesome to have the configuration in a json file (for example
config.json
):then in the code:
and then use
config.token
,config.daemon_host
andconfig.daemon_port
.The interest (for Docker user) is the ability to mount the config (with
--volume
) and then being able to upgrade easily :)If you're interested with that, I can make 3 pull requests:
config.json
and handling them