calypsonet / calypsonet-terminal-calypso-java-api

Deprecated repository containing the old Java code of CNA Terminal Calypso Card API → replaced by https://github.com/eclipse-keypop/keypop-calypso-card-java-api/
https://keypop.org/
Eclipse Public License 2.0
6 stars 3 forks source link

Update the documentation of "prepareReadRecordFile" methods #13

Closed andrei-cristea closed 2 years ago

andrei-cristea commented 2 years ago

CalypsoCardSelection.prepareReadRecordFile(byte sfi, int recordNumber):

CardTransactionManager.prepareReadRecordFile(byte sfi, int recordNumber):

CardTransactionManager.prepareReadRecordFile(byte sfi, int firstRecordNumber, int numberOfRecords, int recordSize):

To keep the API design homogeneous, it is also necessary to modify the signature of all methods that can throw a NoSuchElementException so that they return a null value, empty list, empty map, etc... This will not have a major impact on the version because the behavior of the read methods is more tolerant than before.

jeanpierrefortune commented 2 years ago

The best effort behavior requested must be extended to SFI management, i.e. not generate an error if the file whose SFI is provided does not exist.