calyxir / calyx

Intermediate Language (IL) for Hardware Accelerator Generators
https://calyxir.org
MIT License
495 stars 50 forks source link

Combinational memories in `gen_exp` and `gen_ntt_pipeline` #2062

Closed anshumanmohan closed 4 months ago

anshumanmohan commented 5 months ago

In exactly two places, we use the eDSL to generate combinational and not sequential memories. These are gen_exp and gen_ntt_pipeline. We have discussed that we should use default to sequential memories, and use combinational memories only when we know that the memory is very small. I just wanted to flag these two cases in case we want to revisit them. Porting them over will be very easy.

Originally posted by @anshumanmohan in https://github.com/calyxir/calyx/issues/2052#issuecomment-2128007259

rachitnigam commented 4 months ago

We should use seq_mems instead.