search

calyxir / calyx

Intermediate Language (IL) for Hardware Accelerator Generators
https://calyxir.org
MIT License
460 stars 47 forks source link

[Cider 2] Data converter cannot handle signed values #2161

Open EclecticGriffin opened 2 weeks ago

EclecticGriffin commented 2 weeks ago

What it says on the tin. While I'm mucking about, should change it to use big ints

EclecticGriffin commented 1 week ago

Update, probably not work bothering with BigInts actually. Turns into a big ol' mess. Also seems like serde won't play ball with anything over 128. With that in mind, just using i64 should do the trick for our current needs and can be revisited later if necessary

EclecticGriffin commented 3 days ago

There might be a way to get the desired behavior with serde-json and the arbitrary feature but I think that should generally be considered low priority. There is also the argument that we shouldn't be using Json for loading memory values in the first place