search

calzoneman / sync

Node.JS Server and JavaScript/HTML Client for synchronizing online media
Other
1.47k stars 232 forks source link

[Question] Renewing the dockerfile #774

Closed Gelmo closed 6 years ago

Gelmo commented 6 years ago

Hey Cal,

Have there been any changes to the dockerfile since it was last updated at https://github.com/CyTube/cytube-docker ? If not, please let me know if you intend on renewing this at all. If you don't, just let me know and I'll try to bring it up to date. Are the other new API keys (such as for Mixer, for example) set as ENV vars or are they just called from config files?

Also the FAQ needs to be updated with Mixer and the other new supported site. I'll submit a PR some time this week for it if you don't get around to it first.

Ps: I never heard back from you via email; I assume you got it but if you didn't receive the transfer please let me know. If you did, no need to respond.

calzoneman commented 6 years ago

The Dockerfile was originally contributed by user @davidsiaw in https://github.com/calzoneman/sync/pull/680, where I ended up creating the separate repository and adding him as a maintainer since I don't really use Docker. Looks like it hasn't been updated since the initial proof of concept. If you'd like to help maintain the Dockerfile, please let me know.

I don't remember which of the emails from you you're referring to but I apologize if I forgot to respond, feel free to bump it if it needs a reply.

On Mon, Sep 24, 2018, 04:02 Gelmo notifications@github.com wrote:

Hey Cal,

Have there been any changes to the dockerfile since it was last updated at https://github.com/CyTube/cytube-docker ? If not, please let me know if you intend on renewing this at all. If not just let me know and I'll make it up to date. Are the other new API keys (such as for Mixer, for example) set as ENV vars or are they just called from config files?

Also the FAQ needs to be updated with Mixer and the other new supported site. I'll submit a PR some time this week for it if you don't get around to it first.

Ps: I never heard back from you via email; I assume you got it but if you didn't receive the transfer please let me know. If you did, no need to respond.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/calzoneman/sync/issues/774, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXiiP5wlFsKu1DrKB00CJMBoFDGL6eeks5ueLungaJpZM4W2cTe .

Gelmo commented 6 years ago

Okay, I'll have a go at it and I'll make a PR there once I have something. The email I'm talking about is re: donations, just wanted to make sure you got it

calzoneman commented 6 years ago

Moving discussion to https://github.com/CyTube/cytube-docker/issues/1

calzoneman commented 6 years ago

Also the FAQ needs to be updated with Mixer and the other new supported site.

The FAQ is on a GitHub wiki which should be publicly editable without requiring a PR. However, I've revised it and noted that Mixer is supported. I'm not sure what you mean by "the other new supported site"; Mixer is the only new site added recently and actually a couple sites mentioned on the FAQ had been deprecated.