search

calzoneman / sync

Node.JS Server and JavaScript/HTML Client for synchronizing online media
Other
1.47k stars 234 forks source link

Shuffle Playlist shouldn't shuffle the currently playing item #812

Closed Scritches closed 5 years ago

Scritches commented 5 years ago

When you click the 'Shuffle Playlist' button while a video is playing, that video is included in the shuffle - instead it should leave the currently playing video alone and shuffle the rest of the playlist.

calzoneman commented 5 years ago

I'm not sure I follow. Even when shuffling the same item continues playing even though the list is reordered.

On Fri, May 17, 2019, 20:11 Scritches notifications@github.com wrote:

When you click the 'Shuffle Playlist' button while a video is playing, that video is included in the shuffle - instead it should leave the currently playing video alone and shuffle the rest of the playlist.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/calzoneman/sync/issues/812?email_source=notifications&email_token=AAC6FCBT5MGSCQXKGJR3XM3PV5XURA5CNFSM4HNZM2C2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUQNSKA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAC6FCGICRDHJZBEZCRN3CLPV5XURANCNFSM4HNZM2CQ .

calzoneman commented 5 years ago

Apparently I remembered incorrectly and it does jump to a new video

On Fri, May 17, 2019, 20:19 Calvin Montgomery calzoneman@gmail.com wrote:

I'm not sure I follow. Even when shuffling the same item continues playing even though the list is reordered.

On Fri, May 17, 2019, 20:11 Scritches notifications@github.com wrote:

When you click the 'Shuffle Playlist' button while a video is playing, that video is included in the shuffle - instead it should leave the currently playing video alone and shuffle the rest of the playlist.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/calzoneman/sync/issues/812?email_source=notifications&email_token=AAC6FCBT5MGSCQXKGJR3XM3PV5XURA5CNFSM4HNZM2C2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUQNSKA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAC6FCGICRDHJZBEZCRN3CLPV5XURANCNFSM4HNZM2CQ .

Scritches commented 5 years ago

I could see about putting in a pull request to fix this behavior some time in the next couple days, if you like.