search

calzoneman / sync

Node.JS Server and JavaScript/HTML Client for synchronizing online media
Other
1.46k stars 235 forks source link

update button labels #839

Closed Olie440 closed 4 years ago

Xaekai commented 4 years ago

There is no reason to change these strings.

Olie440 commented 4 years ago

I think it would make it a bit clearer as to what is happening. I used what Spotify uses.

Olie440 commented 4 years ago

@calzoneman What do you think?

calzoneman commented 4 years ago

I'm ok with making the button text more clear, but I'm not sure about the "Add to Playlist" label being used in this context; it could be confused with offering the ability to add the item to a saved/user playlist instead of the channel queue.

I think I would prefer if the buttons had a consistent verb, e.g. "Play next/Play last" or "Add next/Add last"; what do you think?

Xaekai commented 4 years ago

It would seem the consistent verb is already queue internally. Why not Queue next and Queue last

Olie440 commented 4 years ago

@Xaekai Yeah sounds good! Apologies for the way I came in, Last night I discovered the site and got excited about contributing to open source.

Olie440 commented 4 years ago

@calzoneman @Xaekai Btw if you have any tech debt you want doing let me know

Xaekai commented 4 years ago

Can you squash your commits?

Olie440 commented 4 years ago

That should be a option on the merge button right?

Olie440 commented 4 years ago

@Xaekai Thanks so much!