search

calzoneman / sync

Node.JS Server and JavaScript/HTML Client for synchronizing online media
Other
1.46k stars 235 forks source link

Twitch Clips broken again #842

Closed calzoneman closed 4 years ago

calzoneman commented 4 years ago

Creating a tracking issue since multiple people have mentioned it recently.

Problem description

Example link: https://www.twitch.tv/grandpoobear/clip/VenomousCrowdedCaterpillarRiPepperonis

UI shows Cannot read property 'forEach' of undefined

In mediaquery, looks like the API to get the raw video links for the clip is deprecated:

// https://clips.twitch.tv/api/v2/clips/${id}/status
{
  "message": "This Clips route is deprecated."
}
calzoneman commented 4 years ago

As an aside, it seems like Twitch v5 API is already deprecated so while that part is at least working for now (this issue should be resolvable by looking at their current documentation about embeds), there probably needs to be a separate effort to migrate clips+vods to the new API.

calzoneman commented 4 years ago

Embedding a clip is different than embedding a live stream or VOD. The embedded clips player uses a different set of query parameters and does not support the JavaScript interactive embed.

Well ain't that just great.

calzoneman commented 4 years ago

Remaining work: deploy and update documentation to clarify that Twitch clips aren't syncable.

calzoneman commented 4 years ago

Tested on beta.synchtube.me