search

calzoneman / sync

Node.JS Server and JavaScript/HTML Client for synchronizing online media
Other
1.46k stars 235 forks source link

Replaced "display: none" check logic #858

Closed Algoinde closed 4 years ago

Algoinde commented 4 years ago

JQuery queries using getComputedStyle, which makes it impossible to change userlist behavior using CSS. This replaces the check with a direct style="" value check so the JS does not trip up if any CSS customizations to the list visibility were made.

Example: if #userlist is set to display: block !important in the custom CSS, the toggle will break and won't toggle between none and block. Implementing custom CSS leveraging this state change thus is not possible.

Xaekai commented 4 years ago

Strange, you made a feature branch, which is where you should have made this PR.

Yet you did this. Kinda curious why? You can PR directly from a feature branch, then when PR is accepted you can just kill the feature branch and git fetch upstream master (though in this case of this repo replace master with 3.0)

Anyway, LGTM.

Algoinde commented 4 years ago

This is the first time I am doing a pull request through GitHub interface, so I got lost a bit, sorry for that. I see what you mean now. Will this be fine if squashed?

Xaekai commented 4 years ago

Here --> #859