search

calzoneman / sync

Node.JS Server and JavaScript/HTML Client for synchronizing online media
Other
1.45k stars 235 forks source link

Custom-media incorrect handling of empty textTrack array #918

Closed calzoneman closed 3 years ago

calzoneman commented 3 years ago

https://github.com/calzoneman/sync/blob/adfe26aad1f0070260bc40a7e5da9fd054d6f059/player/videojs.coffee#L62

Should check existence and length > 0 explicitly instead of (incorrectly) coalescing to bool.