search

calzoneman / sync

Node.JS Server and JavaScript/HTML Client for synchronizing online media
Other
1.45k stars 235 forks source link

Remove legacy imgur album support #921

Closed calzoneman closed 3 years ago

calzoneman commented 3 years ago

Many, many years ago before custom iframes were supported, CyTube supported queuing imgur albums by URL, which would then embed an iframe using a predetermined URL pattern.

It seems like that no longer works correctly (I tested it to be sure), and nobody ever uses that anyways (I checked recent logs, the only examples within the past year I could find appear not to have been intentional usages of the feature but rather were trying to add a specific image). Best to just remove it and if there is an up to date embed code for imgur people can just use the iframe feature now.

calzoneman commented 3 years ago

Also remove this https://github.com/calzoneman/sync/blob/3.0/player/livestream.com.coffee#L9

calzoneman commented 3 years ago

And this https://github.com/calzoneman/sync/blob/3.0/player/embed.coffee#L34

calzoneman commented 3 years ago

https://github.com/calzoneman/sync/commit/394f03ee1c6ddea2d24f14dd23b89124bc1deefb