removed code that requires application/dash+xml to be live for custom media manifests

calzoneman / sync

Node.JS Server and JavaScript/HTML Client for synchronizing online media

Other

1.45k stars 235 forks source link

removed code that requires application/dash+xml to be live for custom media manifests #946

Closed vt-idiot closed 2 years ago

vt-idiot commented 2 years ago

Tried to base these changes off #768 I tested and can confirm that MPD VODs work just fine. Removing the live check will allow durations and automatic track progression. First commit to src/custom-media.js might have been too much? I removed LIVE_ONLY_CONTENT_TYPES and the validation check entirely since the former would've been empty.

calzoneman commented 2 years ago

Your PR caused a linter failure due to the data parameter no longer being used in validateSources. I fixed it and pushed in https://github.com/calzoneman/sync/commit/dcfcee9a23af906492f9a11edd055976b244588a.

I didn't test this (well, asides from the unit tests), I took your word for it that it works. YMMV.