calzoneman / sync

Node.JS Server and JavaScript/HTML Client for synchronizing online media
Other
1.47k stars 231 forks source link

Improve IP cloaking #956

Open calzoneman opened 2 years ago

calzoneman commented 2 years ago

Apparently the IPv6 cloak only hashes the first 64 bits, meaning that users with different addresses from the same /64 appear as the same IP (e.g., when banning).

Arguably, CyTube should treat addresses within the same /64 as identical (i.e. instead of requiring a range-IPban, IPban should just ban the /64), but regardless, the cloak hash should also probably expose the fact that the addresses are distinct.