search

calzoneman / sync

Node.JS Server and JavaScript/HTML Client for synchronizing online media
Other
1.45k stars 235 forks source link

Add max chat message length config option #967

Closed Kethsar closed 1 year ago

Kethsar commented 1 year ago

Just thought it would be nice. I wanted to increase the max message length of an instance I stood up recently, so that it could be closer to IRC message length. Decided to refactor it into an option instead of just changing the hard coded values.

Kethsar commented 1 year ago

Right, I forgot about those. I had mucked around the filter code a couple of months ago when looking into something before, and it slipped my mind here. I'm not sure I want to mess with those at this time. Would you be opposed to just having a max of 1000 characters set, and checking/setting it in preprocessConfig()? Or would you prefer I close this for now until I may or may not get around to figuring out a good way to integrate the changes with the hardcoded values in the filters?

calzoneman commented 1 year ago

Would you be opposed to just having a max of 1000 characters set, and checking/setting it in preprocessConfig()?

That would be fine. The comment in config.yaml should probably also alert the administrator to this limitation.