[Feature Request] Document PiP

calzoneman / sync

Node.JS Server and JavaScript/HTML Client for synchronizing online media

Other

1.45k stars 235 forks source link

[Feature Request] Document PiP #975

Open i1u5 opened 10 months ago

i1u5 commented 10 months ago

As of Chromium v116, the documentPictureInPicture.requestWindow() method was added, which allows to embed not just the video but any element in the PiP window, this could be useful for subtitles because they stay behind when the PiP button is pressed.

I understand this is a client-side change so it will be possible to accomplish from channel custom JS, but it could still be the default behavior of the video player.

Additional info: VideoJS demo by Chrome devs (source code) Official documentation WICG Explainer

calzoneman commented 10 months ago

Hi,

It seems like this feature isn't available in Firefox; I usually try to constrain core features to things that are standardized and work across all major browsers to reduce user confusion and troubleshooting burden.

Could you explain a little more about the problem you were trying to solve by requesting this feature? There may be an alternative way to support the use case that doesn't rely on nonstandard features.

Xaekai commented 10 months ago

I am among the people who spearheaded/promoted the existence of the dPIP work. You can rest assured that custom subtitle support in PIPs will be coming once Mozilla is onboard with the feature too.

calzone: they want a solution for this. When you activate PIP/video popout mode, layered elements like canvas generated subtitles do not come along for the ride. I agree we should wait for Firefox to support this feature as well before including it in core.