cam-inc / viron

OAS-driven Frontend-NoCode Administration Console
https://discovery.viron.plus/
MIT License
1.02k stars 52 forks source link

Fixed a bug that caused different form autocomplete listings to be displayed #755

Closed JIIOryo closed 11 months ago

JIIOryo commented 11 months ago

Summary

Fixed a bug that could cause a list of autocompletes for different forms to be displayed when using multiple autocompletes at the same time.

The cause was that when using Date.now() to generate autocompleteId, there was a high probability that the same id would be generated for a nearby form.

The id generation logic mimics the following code. https://github.com/cam-inc/viron/blob/7607169afce6b8c9164bc4c2aa5550ba7a8f3149/packages/app/src/components/textinput/index.tsx#L45

Before

After

changeset-bot[bot] commented 11 months ago

🦋 Changeset detected

Latest commit: 9dadda7ee6a829f95eb7d2ccd797aedab4eeddfe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------- | ----- | | @viron/app | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR