search

cam-technologies / time-booker

Web based time booking application, build using the MEEN stack. This application will allow users to manually enter work times in blocks of hours and minutes for each day of the week.
2 stars 7 forks source link

Add unit and e2e tests configs #10

Closed martinmicunda closed 10 years ago

martinmicunda commented 10 years ago

I was not able to run qunit ember test with karma 12 so I am using karma 10.9 for now. E2e is running against angularjs.org page as I need to figure out how to run protractor tests against non angular project.

chrislaughlin commented 10 years ago

What are we uising for node tests I've only seen e2w test before can we unit test

On Thursday, May 22, 2014, Martin Micunda notifications@github.com wrote:

I was not able to run qunit ember test with karma 12 so I am using karma 10.9 for now. E2e is running against angularjs.org page as I need to figure out how to

run protractor tests against non angular project.

You can merge this Pull Request by running

git pull https://github.com/martinmicunda/time-booker master

Or view, comment on, or merge it at:

https://github.com/cam-technologies/time-booker/pull/10 Commit Summary

  • Add unit and e2e tests configs

File Changes

  • M .gitignorehttps://github.com/cam-technologies/time-booker/pull/10/files#diff-0(1)
  • M .travis.ymlhttps://github.com/cam-technologies/time-booker/pull/10/files#diff-1(32)
  • M README.mdhttps://github.com/cam-technologies/time-booker/pull/10/files#diff-2(2)
  • D client/test/README.mdhttps://github.com/cam-technologies/time-booker/pull/10/files#diff-3(1)
  • A client/test/config/dev/unit-runner.htmlhttps://github.com/cam-technologies/time-booker/pull/10/files#diff-4(54)
  • A client/test/config/dev/web-server.jshttps://github.com/cam-technologies/time-booker/pull/10/files#diff-5(245)
  • A client/test/config/karma.conf.jshttps://github.com/cam-technologies/time-booker/pull/10/files#diff-6(145)
  • A client/test/config/protractor.conf.jshttps://github.com/cam-technologies/time-booker/pull/10/files#diff-7(103)
  • A client/test/e2e/example_e2e.jshttps://github.com/cam-technologies/time-booker/pull/10/files#diff-8(47)
  • A client/test/unit/example_test.jshttps://github.com/cam-technologies/time-booker/pull/10/files#diff-9(7)
  • M gulpfile.jshttps://github.com/cam-technologies/time-booker/pull/10/files#diff-10(2)
  • M package.jsonhttps://github.com/cam-technologies/time-booker/pull/10/files#diff-11(5)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/cam-technologies/time-booker/pull/10 .

Regards

Chris Laughlin

martinmicunda commented 10 years ago

I am not sure yet... We need to check that ..

martinmicunda commented 10 years ago

At work we are using tape

martinmicunda commented 10 years ago

I have added ember template compile task to the gulp file.. so templates are compile to client/src/tmp/ember-templates.js file during the development and also there is watch task that watches for changes and compile again... When we are ready for deployment then we can run gulp build --notest that create two js file one vendor file where all 3rd parties lib are concated, minif etc and second app file where apllication code together with templates is concated, minified etc.. I will write email 2mor evening where I explain how the workflow should work....

chrislaughlin commented 10 years ago

Do we close this pull request and open another one, whats the process here now what this pull request needs changes ?

martinmicunda commented 10 years ago

No just merge everything as I have remove dev jasmine runner

chrislaughlin commented 10 years ago

how do you amend an existing pull request ?

martinmicunda commented 10 years ago

i don't amend .. i always push to my master and it will automatically add to existing open request... If i would want to work on another issue i would need to create another branch and push changes there so won't be automatically merge to master is master pull request is still open .. did you get it?

chrislaughlin commented 10 years ago

ah okay, what I have been doing so far os forking then commuting to the master and then pushing that to the forked branch and then make a pull request. Is this the same process you use ? I got the changes merged.

martinmicunda commented 10 years ago

forking to my repo push to my repo create pull request (as it's descripe here, this will automatically pull all your commits that are not in fork repo)

chrislaughlin commented 10 years ago

Cool ill hopefully get a look at the ember test tomorrow

martinmicunda commented 10 years ago

If you open karma.config.js file u can see in line 40 and 43 that I am loading only two files and test passing but if you commented out lines 39 and 42 it start failing .. you can run test unit test with follow command gulp test:unit