camall3n / onager

Lightweight python library for launching experiments and tuning hyperparameters, either locally or on a cluster
MIT License
20 stars 4 forks source link

Prelaunch fails with argument +append #25

Closed camall3n closed 4 years ago

camall3n commented 4 years ago

Argument must be +a or ++append.

Suggest changing to +append.

neevparikh commented 4 years ago

Fixed by 82077ed

camall3n commented 4 years ago

Not fixed.

$ onager prelaunch +arg --foo 1 2 3 +arg --bar a b c +command "./examples/myscript" +jobname test
Traceback (most recent call last):
  File "/Users/cam/dev/onager/venv/bin/onager", line 7, in <module>
    exec(compile(f.read(), __file__, 'exec'))
  File "/Users/cam/dev/onager/bin/onager", line 14, in <module>
    meta_launcher.meta_launch(args)
  File "/Users/cam/dev/onager/onager/meta_launcher.py", line 97, in meta_launch
    if args.append:
AttributeError: 'Namespace' object has no attribute 'append'
camall3n commented 4 years ago
$ onager prelaunch +append +arg --foo 1 2 3 +arg --bar a b c +command "./examples/myscript" +jobname test
Traceback (most recent call last):
  File "/Users/cam/dev/onager/venv/bin/onager", line 7, in <module>
    exec(compile(f.read(), __file__, 'exec'))
  File "/Users/cam/dev/onager/bin/onager", line 14, in <module>
    meta_launcher.meta_launch(args)
  File "/Users/cam/dev/onager/onager/meta_launcher.py", line 97, in meta_launch
    if args.append:
AttributeError: 'Namespace' object has no attribute 'append'
camall3n commented 4 years ago

I'm working on a fix for #26 as well that should fix this too