search

camallo / dkregistry-rs

A pure-Rust asynchronous library for Docker Registry API v2
Apache License 2.0
62 stars 39 forks source link

use async/await and update http, tokio #138

Closed schrieveslaach closed 4 years ago

schrieveslaach commented 4 years ago

@lucab, @steveeJ, this PR adds support for async/await. Please, have a look.

schrieveslaach commented 4 years ago

@steveeJ, how do you want to proceed with this PR? Do you want me to squash the commits and you finished the rest in #140?

steveej commented 4 years ago

@schrieveslaach

Do you want me to squash the commits and you finished the rest in #140?

That sounds good to me. I'll rebase on top of your squashed branch, then Github will automatically detect this one as merged. I'd appreciate if you could help review #140 as well!

schrieveslaach commented 4 years ago

@steveeJ, I squashed the commits. I will have a look at #140 in the next couple of days.

steveej commented 4 years ago

@steveeJ, I squashed the commits. I will have a look at #140 in the next couple of days.

Ah, thanks for that, but could I ask you to split the commtis which touch the Cargo.* files from the code changes, please? We have tried to separate these changes in case code changes need to be reverted without changing the dependencies at one point.

steveej commented 4 years ago

I took the liberty of helping you out with splitting up the commits while preserving your authorship as best as I could. Please take a look at the commit history of #140 and let me know if that's fine for you. I suggest we either close this PR and focus on #140, but I'll leave it up to you.

schrieveslaach commented 4 years ago

@steveeJ, that's fine for me. :+1: